Skip to content

Commit

Permalink
make it the default (#13556)
Browse files Browse the repository at this point in the history
  • Loading branch information
nisdas authored Jan 31, 2024
1 parent 7a294e8 commit 73ce28c
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 8 deletions.
7 changes: 4 additions & 3 deletions config/features/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,10 @@ func ConfigureBeaconChain(ctx *cli.Context) error {
logEnabled(enableFullSSZDataLogging)
cfg.EnableFullSSZDataLogging = true
}
if ctx.IsSet(enableVerboseSigVerification.Name) {
logEnabled(enableVerboseSigVerification)
cfg.EnableVerboseSigVerification = true
cfg.EnableVerboseSigVerification = true
if ctx.IsSet(disableVerboseSigVerification.Name) {
logEnabled(disableVerboseSigVerification)
cfg.EnableVerboseSigVerification = false
}
if ctx.IsSet(prepareAllPayloads.Name) {
logEnabled(prepareAllPayloads)
Expand Down
6 changes: 6 additions & 0 deletions config/features/deprecated_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ var (
Usage: deprecatedUsage,
Hidden: true,
}
deprecatedVerboseSigVerification = &cli.BoolFlag{
Name: "enable-verbose-sig-verification",
Usage: deprecatedUsage,
Hidden: true,
}
)

// Deprecated flags for both the beacon node and validator client.
Expand All @@ -90,6 +95,7 @@ var deprecatedFlags = []cli.Flag{
deprecatedDisableOptionalEngineMethods,
deprecatedDisableAggregateParallel,
deprecatedEnableEIP4881,
deprecatedVerboseSigVerification,
}

// deprecatedBeaconFlags contains flags that are still used by other components
Expand Down
9 changes: 4 additions & 5 deletions config/features/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@ var (
Name: "enable-beacon-rest-api",
Usage: "(Experimental): Enables of the beacon REST API when querying a beacon node.",
}
enableVerboseSigVerification = &cli.BoolFlag{
Name: "enable-verbose-sig-verification",
Usage: "Enables identifying invalid signatures if batch verification fails when processing block.",
disableVerboseSigVerification = &cli.BoolFlag{
Name: "disable-verbose-sig-verification",
Usage: "Disables identifying invalid signatures if batch verification fails when processing block.",
}
prepareAllPayloads = &cli.BoolFlag{
Name: "prepare-all-payloads",
Expand Down Expand Up @@ -159,7 +159,6 @@ var (

// devModeFlags holds list of flags that are set when development mode is on.
var devModeFlags = []cli.Flag{
enableVerboseSigVerification,
enableExperimentalState,
backfill.EnableExperimentalBackfill,
}
Expand Down Expand Up @@ -201,7 +200,7 @@ var BeaconChainFlags = append(deprecatedBeaconFlags, append(deprecatedFlags, []c
SaveFullExecutionPayloads,
enableStartupOptimistic,
enableFullSSZDataLogging,
enableVerboseSigVerification,
disableVerboseSigVerification,
prepareAllPayloads,
aggregateFirstInterval,
aggregateSecondInterval,
Expand Down

0 comments on commit 73ce28c

Please sign in to comment.