-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
on_vm_start is called multiple times when multiple plugins exist in a single VM. #192
Comments
I think it was done deliberately to retain some backward compatibility, since otherwise only Having said that, do you have any use for this? I was thinking about completely removing |
actually I don't use this, and +1 to the idea that everything should be scoped to plugins. Btw what's your current thoughts on multiple plugins per 1 VM thing? That is somewhat related to that ABI change. |
WasmBase::start is called for every plugin;
proxy-wasm-cpp-host/src/wasm.cc
Line 593 in 668bc99
and inside of it ContextBase::onStart is called:
proxy-wasm-cpp-host/src/wasm.cc
Line 395 in 668bc99
that results in calling on_vm_start:
proxy-wasm-cpp-host/src/context.cc
Lines 137 to 142 in 668bc99
The text was updated successfully, but these errors were encountered: