Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fallback exchange #15

Open
provinzio opened this issue Mar 2, 2021 · 5 comments
Open

Implement fallback exchange #15

provinzio opened this issue Mar 2, 2021 · 5 comments
Labels
help wanted Extra attention is needed PriceData

Comments

@provinzio
Copy link
Owner

provinzio commented Mar 2, 2021

Binance for example does not provide full historical data for all pairs.
We should implement a fallback like coinbase, coinmarketcape, coingecko ... for situations where we can not retrieve historical prices from an exchange.

We should add an additional column to our price database which holds the fallback exchange in case one was used.

@scientes
Copy link
Contributor

scientes commented Jan 1, 2022

even with #16 we will still need a fallback for when we cant get historical data from exchanges e.g for coins which are traded through smart contracts only. Coingecko seems like the ideal fallback due to not requiring a api key.

@scientes
Copy link
Contributor

scientes commented Jan 1, 2022

@Griffsano
Copy link
Contributor

From what I've seen, the problem with Coingecko is that there's only daily historic data available.
CryptoCompare offers daily/hourly/minutely historic OHLCV data, but apparently only for certain coins: https://min-api.cryptocompare.com/documentation

There are already Python wrappers for the two options that we could include:
https://github.com/lagerfeuer/cryptocompare
https://github.com/man-c/pycoingecko

@provinzio
Copy link
Owner Author

In that case. Crypto compare sounds like a good option. We should definitely start to add a remark column to alle prices in our db to mark from where the price information comes.

Any perhaps a second column, when the price is not exactly for the timestamp but for the day or 5 seconds ago.

@scientes
Copy link
Contributor

scientes commented Apr 9, 2022

I wanted to add custom non ccxt exchanges to the ohlcv Implementation (defi, coingecko, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed PriceData
Projects
None yet
Development

No branches or pull requests

3 participants