-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement fallback exchange #15
Comments
even with #16 we will still need a fallback for when we cant get historical data from exchanges e.g for coins which are traded through smart contracts only. Coingecko seems like the ideal fallback due to not requiring a api key. |
From what I've seen, the problem with Coingecko is that there's only daily historic data available. There are already Python wrappers for the two options that we could include: |
In that case. Crypto compare sounds like a good option. We should definitely start to add a remark column to alle prices in our db to mark from where the price information comes. Any perhaps a second column, when the price is not exactly for the timestamp but for the day or 5 seconds ago. |
I wanted to add custom non ccxt exchanges to the ohlcv Implementation (defi, coingecko, etc) |
Binance for example does not provide full historical data for all pairs.
We should implement a fallback like coinbase, coinmarketcape, coingecko ... for situations where we can not retrieve historical prices from an exchange.
We should add an additional column to our price database which holds the fallback exchange in case one was used.
The text was updated successfully, but these errors were encountered: