Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies causes pip to install every version of ccxt #111

Closed
jhoogstraat opened this issue Mar 21, 2022 · 7 comments
Closed

Comments

@jhoogstraat
Copy link
Contributor

When installing the dependencies using pip install -r requirements.txt every version of ccxt gets installed.

Example:

Downloading ccxt-1.64.31-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB 6.8 MB/s
  Downloading ccxt-1.64.30-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.29-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.28-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.27-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.26-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB 6.8 MB/s
  Downloading ccxt-1.64.25-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.24-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.23-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB ...
  Downloading ccxt-1.64.22-py2.py3-none-any.whl (2.2 MB)
     |████████████████████████████████| 2.2 MB 6.8 MB/s
@scientes
Copy link
Contributor

Which pip Version are you using?
And which Branch are you using (prob the ohlcv Branch)
The only similar ocurrence i found Was this: pypa/pip#9284

@jhoogstraat
Copy link
Contributor Author

jhoogstraat commented Mar 21, 2022

Yep, I was just testing different branches. I rebased the ohlcv branch onto main though.
I used pip 21, windows machine.

@scientes
Copy link
Contributor

pypa/pip#9284 (comment)

It just could be that what you expirience is Not a Bug per se but a feature of pip, called backtracking.

@jhoogstraat
Copy link
Contributor Author

The issue is that ccxt has a minimum version, while its dependencies are locked to a specific version. I think it would be better to just include the direct dependencies, like so:

ccxt>=1.76.91
python-dateutil==2.8.2
requests==2.27.1

@scientes
Copy link
Contributor

yeah i need to look at the python modules some are not needed anymore i think. also i couldn't replicate your bug/feature and including the direct dependencies can lead to more issues, e.g. if ccxt updates their dependency version and we locked them pip will throw an error

@jhoogstraat
Copy link
Contributor Author

jhoogstraat commented Mar 23, 2022

True, that's what I meant!
There are only 3 dependencies that have to go into requirements.txt (see list above).

@provinzio
Copy link
Owner

I close this issue, as this regarding an unfinished PR #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants