Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big differences comparing MKR votes of a poll between the dashboard and vote.makerdao #420

Open
cmalfesi opened this issue Jun 11, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@cmalfesi
Copy link
Contributor

I have detected an issue comparing MKR votes of a poll between the dashboard and vote.makerdao.
This are the link compared:
1- https://mkr-gov.netlify.app/poll/184 > MKR 37082.35
2- https://vote.makerdao.com/polling-proposal/qmsv7qsmqafardbhun2f9s65nge3xf5oe4we3dswzwbtfy > MKR 26,555.63
You can see that there is a big difference.
Lisandro has checked manually all values of every voter and here I send you a spreadsheet where you can see that our calculation looks good, it matches with the Dashboard.
https://docs.google.com/spreadsheets/d/1y-2RME38AML2gazlGsMDWHC_cRjLDKz_NthYTgyZ8Ec/edit?usp=sharing

@cmalfesi cmalfesi added the bug Something isn't working label Jun 11, 2020
@cmalfesi
Copy link
Contributor Author

cmalfesi commented Jun 11, 2020

Answer from Derek Flossman:
Hi cristian.malfesi and lisandro.corbalan , we identified this to be the result of an edge case that's always existed. What happened was that a whale with 10,526 MKR created a vote proxy with MKR in his cold wallet, but didn't move the MKR into the vote proxy until after the vote ended. https://etherscan.io/address/0x8dd0dc203090591183b7b26203a911e6a220b3bd#tokentxns

I’m meeting with the Devs on Monday to walk-through some solutions, define better messaging and honestly to better understand the details of what happened. (it will either involve us adjusting polling vote power expectations to not include the mkr balance of the cold wallet attached to a vote proxy or some new calculations to account for the above case), I’ll follow up with you on our direction and to help us align on showing the same data. Thanks for reaching out guys.

@cmalfesi
Copy link
Contributor Author

image

@cmalfesi
Copy link
Contributor Author

The last status is: Maker team is checking how to calculate in the right way the MKR in a vote. We are waiting that they inform us if we need to improve or change the formulas.

@cmalfesi
Copy link
Contributor Author

image.png

@cmalfesi
Copy link
Contributor Author

image.png

@cmalfesi
Copy link
Contributor Author

by derek.flossman:
Attaching a doc describing Ranked Choice in case you guys find it useful for your implementation

https://app.zenhub.com/files/204923920/ee519234-508e-4681-9538-7a559dd2bccd/download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant