Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Option to respect .gitignore #494

Open
NoamNol opened this issue Mar 1, 2022 · 4 comments
Open

[FEATURE REQUEST] Option to respect .gitignore #494

NoamNol opened this issue Mar 1, 2022 · 4 comments
Labels
enhancement file-finder-rewrite The plan to replace the file finder in prospector should include this bug

Comments

@NoamNol
Copy link

NoamNol commented Mar 1, 2022

Add option to ignore all files in .gitignore.

In ESLint it's possible with:

eslint --ignore-path .gitignore

Related to #445 (but now I don't ask to change the default behavior)

@carlio
Copy link
Contributor

carlio commented Mar 1, 2022

Out of curiosity, which python files to you keep locally which are not checked in which prospector would otherwise pick up? Has this been a problem so far?

Virtual environments and tox config should already be automatically ignored.

I agree that this feature makes sense, I just want to understand the use case better to help me understanding when implementing it.

@carlio carlio added the file-finder-rewrite The plan to replace the file finder in prospector should include this bug label Mar 1, 2022
@NoamNol
Copy link
Author

NoamNol commented Mar 1, 2022

In my case I have a folder for private code ignored by git.

@carlio
Copy link
Contributor

carlio commented Mar 1, 2022

Ok I see.

I will park this for now, because I have a plan to rewrite how prospector finds files to inspect as it is. I have to clean out the backlog of bugs first, but once that is done I'll move onto the file-finder-rewrite (see the label) and include this.

@NoamNol
Copy link
Author

NoamNol commented Mar 1, 2022

Great! and I think in the future prospector can move to ignorefiles (one or many) and completely remove the ignore-paths and ignore-patterns options.

But this is beyond the scope of this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement file-finder-rewrite The plan to replace the file finder in prospector should include this bug
Projects
None yet
Development

No branches or pull requests

2 participants