Skip to content
This repository has been archived by the owner on Jul 7, 2021. It is now read-only.

client/user token implementations leak credentials in logs #243

Closed
ChristianSch opened this issue Oct 8, 2019 · 2 comments · Fixed by #356
Closed

client/user token implementations leak credentials in logs #243

ChristianSch opened this issue Oct 8, 2019 · 2 comments · Fixed by #356
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ChristianSch
Copy link
Contributor

Hi,

As both client and user token implementations use query strings, the credentials can actually leak in any logs on the server (mine/our/the clients). It is preferred to actually include them in the request body instead. Quoting the api doc:

• Even though finAPI is not logging query parameters, it is still recommended to pass the parameters in the POST body instead of in the URL. Also, please set the Content-Type of your request to 'application/x-www-form-urlencoded' when calling this service.

Relevant: #37

@proshin-roman
Copy link
Owner

Hi Christian,
thanks for the request!
Yes, you're right about this issue - all credentials should be submitted in the body of a request. This is a bug and it will be fixed (feel free to submit a pull request).

@proshin-roman proshin-roman added bug Something isn't working help wanted Extra attention is needed labels Dec 22, 2019
@ccostin93 ccostin93 self-assigned this Nov 20, 2020
@ccostin93
Copy link
Collaborator

@proshin-roman Will try to fix this issue over the weekend

ccostin93 added a commit that referenced this issue Nov 21, 2020
ccostin93 added a commit that referenced this issue Nov 21, 2020
@ccostin93 ccostin93 linked a pull request Nov 21, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants