Remove iDEAL issuers for iDEAL 2.0 migration

[rvdsteege]

To migrate to iDEAL 2.0, Mollie advises merchants (by email and on https://help.mollie.com/hc/en-gb/articles/19100313768338-iDEAL-2-0) to remove the issuers:

1. Check whether there is a bank selection dropdown (also referred to as issuer selection) on your checkout page.
2. If no dropdown appears, no further action is required.
3. If there is a bank selection dropdown, remove it and instead only display the iDEAL logo and payment method name to the consumer. Additionally, stop sending in the Issuer ID in your ‘Create payment’ request.
4. Once you stop sending in the Issuer ID, the response to the API call will include the link to the new iDEAL hosted page, where the consumer will select their issuing bank for the iDEAL payment.

NOTE: in case you are using the Methods API to dynamically receive the list of issuers for iDEAL, you can remove this step from your integration.

In e.g. https://secure.helpscout.net/conversation/2642194046/27452 a customer enquired about how to remove the issuers with our WooCommerce integration, but merchant have no control over this at the moment. Currently, we're always adding issuers to the iDEAL payment method:

wp-pronamic-pay-mollie/src/Gateway.php

Lines 112 to 118 in 8c5e8d4

	// Fields.
	$ideal_options = new CachedCallbackOptions(
	function () {
	return $this->get_ideal_issuers();
	},
	'pronamic_pay_ideal_issuers_' . \md5( (string) \wp_json_encode( $config ) )
	);

wp-pronamic-pay-mollie/src/Gateway.php

Lines 218 to 221 in 8c5e8d4

	$field_ideal_issuer = new IDealIssuerSelectField( 'pronamic_pay_mollie_ideal_issuer' );
	$field_ideal_issuer->set_options( $ideal_options );
	$payment_method_ideal->add_field( $field_ideal_issuer );

wp-pronamic-pay-mollie/src/Gateway.php

Lines 380 to 395 in 8c5e8d4

	/**
	* Get iDEAL issuers.
	*
	* @return iterable<SelectFieldOption|SelectFieldOptionGroup>
	*/
	private function get_ideal_issuers() {
	$issuers = $this->client->get_issuers();
	$items = [];
	foreach ( $issuers as $key => $value ) {
	$items[] = new SelectFieldOption( $key, $value );
	}
	return $items;
	}

[remcotolsma]

As far as I know, technically the 'old' iDEAL from Mollie with issuer ID can also run on the new iDEAL 2.0 platform. From the iDEAL 2.0 integrations of Rabobank and ING, we know that the new iDEAL 2.0 platform also supports an issuer ID for a smooth transition. For many, however, iDEAL 2.0 will also mean using the new iDEAL hosted page. This should ideally also be the standard, but this cannot yet be set within Pronamic Pay. Should we (temporarily) introduce an additional setting for this in the WooCommerce iDEAL gateway?

☑️ Show iDEAL bank list
With the developments of iDEAL 2.0, the bank list will eventually disappear, but for now this functionality is still available for a smooth transition.

However, for new Pronamic Pay installations this setting should be off by default, and for existing installations it may be on by default. This so that users can consciously choose to use the iDEAL 2.0 hosted payment page. If we had kept an installation date, we could have easily done something with this? But without this information it is difficult to implement this way?

Should we add something like this in the installation routine:

$installation_date = (string) \get_option( 'pronamic_pay_installation_date', '' );

if ( '' === $installation_date ) {
	\update_option( 'pronamic_pay_installation_date', \current_time( 'mysql', true ) );
}

Originally posted by @remcotolsma in pronamic/wp-pay-core#186 (comment)

I did notice some support topics on https://wordpress.org/support/plugin/mollie-payments-for-woocommerce/ as a result of automatically removing the bank list option field.

[rvdsteege]

We can start adding the installation date for new installations and use it for this setting?

[remcotolsma]

I also just realized that we have a WooCommerce gateway configuration post publication date available that we can use. If the show_ideal_issuer_selection_field option is null and gateway configuration publication date is if before 2024-07-01 enable the option by default, otherwise disabled by default.

[rvdsteege]

From customer in https://freescout.pronamic.nl/conversation/753:

Nu heb ik op dezelfde website de woocommerce webshop al omgezet naar IDeal 2.0. Alleen bij de Memberpress lidmaatschap betalingen lopen via Pronomic pay, via betaalmethode 'Pronamic - Incasso (machtiging via iDEAL)'.

Mijn vraag: moet ik voor deze incasso via Ideal ook overstappen naar Ideal 2.0? En hoe doe ik dat?

@remcotolsma do we also need / want a setting like pronamic/wp-pronamic-pay-woocommerce#73 in MemberPress (and possibly others)?

[remcotolsma]

Als je dit niet doet, worden je klanten twee keer gevraagd om hun bank te selecteren - één keer in je checkout (zonder effect) en dan nog een keer op de betaalpagina van iDEAL.

Zorg ervoor dat de keuze voor de kaartuitgever vóór 1 maart 2025 uit je kassa is verwijderd.

• Actie vereist: Verwijder de keuze voor de kaartuitgever uit je checkout #62

Let's remove it from this integration, PRs are open:

• Remove iDEAL issuers code #63
• Remove iDEAL issuers code wp-mollie#8

[rvdsteege]

If we suddenly remove the iDEAL issuers, I foresee issues with Gravity Forms and required issuers fields resulting in user being unable to submit a form until the issuers field is removed manually by an administrator:

I've opened an issue + PR to prevent these issues:

• Prevent validation issues with issuers fields without choices wp-pronamic-pay-gravityforms#47
• Remove empty issuers field during form render. wp-pronamic-pay-gravityforms#48

Aside from that, seems fine to remove the iDEAL issuers from this integration.

[remcotolsma]

PRs are merged:

• Prevent validation issues with issuers fields without choices wp-pronamic-pay-gravityforms#47
• Remove empty issuers field during form render. wp-pronamic-pay-gravityforms#48