Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle issue description being too large. #41

Closed
bwplotka opened this issue Aug 16, 2019 · 6 comments · Fixed by #165
Closed

Gracefully handle issue description being too large. #41

bwplotka opened this issue Aug 16, 2019 · 6 comments · Fixed by #165

Comments

@bwplotka
Copy link
Member

bwplotka commented Aug 16, 2019 •
edited
Loading

We got that because we put too much stuff on the JIRA issue while creating. The limit was around 32k chars. I feel like we could do better in Jiralert to truncate the description automatically if too large?

Want to start a discussion on it (:
@bill3tt
Copy link

bill3tt commented Aug 16, 2019 •
edited
Loading

There is a jira.text.field.character.limit set to 32767 by default in JIRA Cloud.

From JRASERVER-64351. Though it appears like this limit can be increased when self-hosting.

One solution, that should cover both cases would be:

  • Default to truncating text fields at 32767 characters, emitting a WARN log line when truncation has happened.
  • Include a flag to arbitrarily set this limit e.g. --char.limit

@bumarcell
Copy link

Did it happen? :D

@bwplotka
Copy link
Member Author

Nope, help wanted.

@twotired twotired mentioned this issue May 10, 2023
Merged
@gerry-c-wd
Copy link

Nope, help wanted.

@bwplotka Does this PR help or do you have any feedback for the author?
#165

@bwplotka
Copy link
Member Author

Thanks for ping 💪🏽 It indeed helped

@gerry-c-wd
Copy link

gerry-c-wd commented Jul 10, 2023 •
edited
Loading

Thank you for your time @bwplotka.

If you have a little time to spare. There are also PRs for:
#152 (help also requested there) - (single line addition in the PR)
#159
#161 (two alternative PRs there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

truncate descriptions that exceed -max-description-length (default 32KB) twotired/jiralert
4 participants
@bwplotka @bumarcell @bill3tt @gerry-c-wd