Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[all] Add new helm-charts admins #5137

Open
SuperQ opened this issue Jan 13, 2025 · 14 comments
Open

[all] Add new helm-charts admins #5137

SuperQ opened this issue Jan 13, 2025 · 14 comments
Assignees
Labels
admin Issue for repo admins question Further information is requested

Comments

@SuperQ
Copy link
Contributor

SuperQ commented Jan 13, 2025

Hello existing @prometheus-community/helm-charts-admins

I would like to propose expanding the admins of this repo to additional maintainers. Over the last couple years we have had several new active maintainers. I would propose they would be excellent new admins for the helm-charts repo.

image

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 13, 2025

CC @DrFaust92 @zanhsieh @zeritti @jkroepke

If you would like to become part of the admin team, please reply YES.

@jkroepke
Copy link
Member

YES

2 similar comments
@zeritti
Copy link
Member

zeritti commented Jan 13, 2025

YES

@DrFaust92
Copy link
Contributor

YES

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 13, 2025

@scottrigby @monotek @torstenwalter, as current admins, please respond with APPROVE if you would like to invite these new admins.

@zanhsieh
Copy link
Contributor

zanhsieh commented Jan 14, 2025

YES

@torstenwalter
Copy link
Member

@monotek @scottrigby I'd be in favour of adding new admins.

@scottrigby
Copy link
Member

I think it's good to have new folks who have been active. Just making sure, is it clear to everyone what the admin responsibilities are?

An important note is a number of charts in this repo are seen as trusted infrastructure for many production clusters around the world. We've been very careful to ensure this repo is set up securely, and all administrative changes are transparently communicated and documented (for example, see https://github.com/prometheus-community/helm-charts/blob/main/PROCESSES.md#github-settings). Is this something you all agree to and do you have a good communication protocol in place before making administrative changes to the repo?

@scottrigby scottrigby added the question Further information is requested label Jan 14, 2025
@jkroepke
Copy link
Member

Hi @scottrigby

I can just talk for myself. I'm aware of the criticality of this repository. I have got advanced experience as maintainer on other community projects, e.g. windows_exporter or personal project like helm-secrets.

@SuperQ recently created a Slack Channel related to helm-charts in order to establish a communication channel.

However, the responsibilities of an admin are not entirely clear. I understand that an admin is responsible for onboarding new maintainers, managing new Helm charts, and handling other repository-related settings. However, there are no documented rules or criteria for accepting new maintainers or charts.

Additionally, there don't appear to be any formal decision-making rules. As far as I can tell, decisions are currently made through informal consensus, which I find acceptable since it is still a community-driven repository.

@SuperQ SuperQ added the admin Issue for repo admins label Jan 14, 2025
@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 14, 2025

Technically, as the project is part of the Prometheus Community, it falls under the Prometheus Governance rules.

But none of these really conflict with how an individual project/repo wants to conduct technical decision making.

@scottrigby
Copy link
Member

@jkroepke, thanks, definitely satisfies what i was asking 👍

Just for due diligence, it would be good to hear a response to this question from the others nominated too. @SuperQ you may have had that chat with them elsewhere-do you mind if we move that here or hear from the others here too?

Re slack, where is that-do you want to invite us to that as well?

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 15, 2025

The slack channel is on the CNCF Slack, listed on https://prometheus.io/community/

@DrFaust92
Copy link
Contributor

Makes sense to me, similar to other maintainers I have several projects that are widely used and lots of companies production depends on those in the terraform space.

The aforementioned slack channel (prom-helm-charts) sounds like a great place to update on changes/get consensus

@SuperQ
Copy link
Contributor Author

SuperQ commented Jan 18, 2025

@scottrigby @monotek @torstenwalter, since there's no formal process for adding new admins we have a couple simple options we could use here.

  • Majority vote
  • Rough consensus

For a majority vote, how about replying to the thread with APPROVE @username?

For rough consensus, we can give this as a week and if nobody objects to specific users, they can be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issue for repo admins question Further information is requested
Projects
None yet
Development

No branches or pull requests

8 participants