Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kube-prometheus-stack] kubernetes-mixin dashboards links do not work anymore #4255

Closed
FlorisFeddema opened this issue Feb 16, 2024 · 10 comments · Fixed by #4297
Closed

[kube-prometheus-stack] kubernetes-mixin dashboards links do not work anymore #4255

FlorisFeddema opened this issue Feb 16, 2024 · 10 comments · Fixed by #4297
Labels
bug Something isn't working

Comments

@FlorisFeddema
Copy link
Contributor

Describe the bug a clear and concise description of what the bug is.

When using the kubernetes-mixin dashboads the links to more in-depth dashboard do not work.
For example if I open the Kubernetes / Compute Resources / Workload dashboard and click on one of the rows in the CPU Quota table it links to another dashboard. However the url of this dashboard does not seem to be working.

These are the parameters I end up with:
image

What's your helm version?

v3.10.3

What's your kubectl version?

v1.28.2

Which chart?

kube-prometheus-stack

What's the chart version?

56.6.2

What happened?

Went to the Kubernetes / Compute Resources / Workload dashboard and clicked on one of the rows in the CPU Quota table. The newly opened page does not have the correct paramters.

What you expected to happen?

The newly opened page to use the parameters of the tablerow to fill in the next dashboard parameters.

How to reproduce it?

Deploy kube prometheus stack with grafana and the dashboards.
Navigate to the Kubernetes / Compute Resources / Workload dashboard and click on one of the rows in the CPU Quota table.

Enter the changed values of values.yaml?

NONE

Enter the command that you execute and failing/misfunctioning.

The install worked.

Anything else we need to know?

No response

@FlorisFeddema FlorisFeddema added the bug Something isn't working label Feb 16, 2024
@fctb
Copy link

fctb commented Feb 17, 2024

Click on pod name (drill down) forward not the pod name. The url contains: &var-pod=${__value.text} instead of the pod name.
Likly came from here: 4087
I use grafana 10.3.1

Could it be that new $vars don't work with old panels, which are deprecated baut here still used?
Or do we miss an dashboard update to switch to panels?

@zeritti zeritti changed the title [prometheus-kube-stack] kubernetes-mixin dashboards links do not work anymore [kube-prometheus-stack] kubernetes-mixin dashboards links do not work anymore Feb 21, 2024
@FlorisFeddema
Copy link
Contributor Author

I tried some things and I could not get the links working with the new vars indeed.

The links result in the following data fields:
image

@jkroepke
Copy link
Member

Thats strange. I implement this, because the old table panel wont work with the old variables.

However I have multiple grafana instances, where is issues does not appear. Currently, I'm at 10.3.3, but it worked with 10.2.x.

For any reasons. Grafana always to an automatic migration of the table panel. Seems like this is not the case on your site.

Could you please generate an json export?

image

@FlorisFeddema
Copy link
Contributor Author

Here is the export of our dashboard. We have about 30 environments where we run Grafana and they all have the same problem.
I have also deleted the pvc and recreated the grafana instance.
Kubernetes _ Compute Resources _ Workload-1708936097167.json

@jkroepke
Copy link
Member

If you are try to edit the table panal, does Grafana offer the migration?

@FlorisFeddema
Copy link
Contributor Author

I don't see any option to do the migration in Grafana. We run version 10.3.3

This is what we get when we edit the panel:
image

@jkroepke
Copy link
Member

Ah. Do you have an test instance, where you could set on grafana.ini:

[security]
angular_support_enabled = false

Ref: https://grafana.com/docs/grafana/latest/setup-grafana/configure-grafana/#angular_support_enabled

Looking at source, if this is set, it will auto-migrate the old table:

https://github.com/grafana/grafana/blob/648abdbd0ea4451a102601dec874c770d635eb12/public/app/features/dashboard/state/DashboardModel.ts#L172-L174

This explain it to me and we may need an values toggle here.

@FlorisFeddema
Copy link
Contributor Author

I have deployed it on one of our test instances and after disabling the angular support flag in the grafana config it automatically migrated the tables to the new one!

@jkroepke
Copy link
Member

jkroepke commented Feb 27, 2024

I implement a toggle so it will work for both scenario now, once the PR is merged.

@pierreozoux
Copy link

@jkroepke we think we have the same issue on the node dashboard.

we attached a PR to this bug report:
#4828

Did you modify upstream https://github.com/kubernetes-monitoring/kubernetes-mixin repo, or just here?
We'd like to submit a proper PR, but are a bit lost to be honest :) If you could this would be nice!

Thanks for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants