From 45b5403a47e869b07c8c71440d87a4428f191771 Mon Sep 17 00:00:00 2001 From: t3mi Date: Sat, 21 Oct 2023 11:31:04 +0000 Subject: [PATCH] [prometheus-json-exporter] fix configmap name according to standard Signed-off-by: t3mi --- charts/prometheus-json-exporter/Chart.yaml | 2 +- charts/prometheus-json-exporter/README.md | 5 +++++ charts/prometheus-json-exporter/templates/configmap.yaml | 2 +- charts/prometheus-json-exporter/templates/deployment.yaml | 2 +- 4 files changed, 8 insertions(+), 3 deletions(-) diff --git a/charts/prometheus-json-exporter/Chart.yaml b/charts/prometheus-json-exporter/Chart.yaml index 0372c58d1d11..7de7dd23a45f 100644 --- a/charts/prometheus-json-exporter/Chart.yaml +++ b/charts/prometheus-json-exporter/Chart.yaml @@ -19,7 +19,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.7.3 +version: 0.8.0 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to diff --git a/charts/prometheus-json-exporter/README.md b/charts/prometheus-json-exporter/README.md index c2348c432d0f..5375a10cc824 100644 --- a/charts/prometheus-json-exporter/README.md +++ b/charts/prometheus-json-exporter/README.md @@ -46,6 +46,11 @@ _See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command doc $ helm upgrade [RELEASE_NAME] [CHART] --install ``` +### From 0.7.x to 0.8.0 + +This version fixes configmap name according to the chart standard so that configmap will be recreated with subsequent deployment rollout. +See [#3926](https://github.com/prometheus-community/helm-charts/pull/3926) for more context. + ## Configuring See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands: diff --git a/charts/prometheus-json-exporter/templates/configmap.yaml b/charts/prometheus-json-exporter/templates/configmap.yaml index afea5c17b40b..e68ccbb780e4 100644 --- a/charts/prometheus-json-exporter/templates/configmap.yaml +++ b/charts/prometheus-json-exporter/templates/configmap.yaml @@ -1,7 +1,7 @@ apiVersion: v1 kind: ConfigMap metadata: - name: {{ .Release.Name }}-configmap + name: {{ include "prometheus-json-exporter.fullname" . }} data: allow-snippet-annotations: "false" config.yml: | diff --git a/charts/prometheus-json-exporter/templates/deployment.yaml b/charts/prometheus-json-exporter/templates/deployment.yaml index 3069dbf5e9a7..b2d149cb6b0b 100644 --- a/charts/prometheus-json-exporter/templates/deployment.yaml +++ b/charts/prometheus-json-exporter/templates/deployment.yaml @@ -69,7 +69,7 @@ spec: volumes: - name: config-configmap-volume configMap: - name: {{ .Release.Name }}-configmap + name: {{ include "prometheus-json-exporter.fullname" . }} items: - key: config.yml path: config.yml