Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm chart specification to follow best practices #74

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

simu
Copy link
Member

@simu simu commented Nov 24, 2023

Additionally, we update the component to use ${_base_directory} in class/vault.yml.

This is a breaking change for configurations which customize the Helm chart version.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@simu simu added the breaking label Nov 24, 2023
@simu simu requested a review from a team November 24, 2023 10:35
@simu simu merged commit 172be94 into master Nov 24, 2023
6 checks passed
@simu simu deleted the helm-version-spec branch November 24, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants