Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow component to manage additional facts config map #65

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Allow component to manage additional facts config map #65

merged 4 commits into from
Nov 14, 2023

Conversation

bastjan
Copy link
Contributor

@bastjan bastjan commented Nov 14, 2023 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

@bastjan bastjan added the enhancement New feature or request label Nov 14, 2023
@bastjan bastjan requested a review from simu November 14, 2023 15:47
@bastjan bastjan force-pushed the add-additional-facts-config-map branch from c3f4865 to de824ca Compare November 14, 2023 15:54
@bastjan bastjan marked this pull request as ready for review November 14, 2023 15:54
@bastjan bastjan changed the title Add additional facts config map Allow component to manage additional facts config map Nov 14, 2023
@bastjan bastjan force-pushed the add-additional-facts-config-map branch from de824ca to 1e5def3 Compare November 14, 2023 15:55
@bastjan bastjan force-pushed the add-additional-facts-config-map branch from 1e5def3 to 25b2815 Compare November 14, 2023 16:12
@bastjan bastjan merged commit 021ff0d into master Nov 14, 2023
6 checks passed
@bastjan bastjan deleted the add-additional-facts-config-map branch November 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebakelOrakel DebakelOrakel DebakelOrakel approved these changes

@simu simu simu approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastjan @simu @DebakelOrakel