Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Remove certificate management from component #134

Open
mhutter opened this issue May 20, 2022 · 1 comment
Open

Proposal: Remove certificate management from component #134

mhutter opened this issue May 20, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mhutter
Copy link
Contributor

mhutter commented May 20, 2022

Context

Managing the certificates for incoming traffic (for edge, passthrough and reencrypt setups) make this component unnecessarily complex. The component tries to deduct from all the input, what certificates must be created from which source and configured in which way for Keycloak itself and the Ingress object. (also see #115 and #99 #98 #96 )

I would propose to remove the whole certificate creation logic from this component, and leave it to dedicated components or the user.

In this component:

  • select a TLS mode
  • optionally annotate services (such as to generate OpenShift Service Serving Certs)
  • configure which secret to use for certificates (igress and/or Keycloak)

Alternatives

  • Only expose Helm Values via this component
  • Provide config examples in the documentation
@mhutter mhutter added the enhancement New feature or request label May 20, 2022
@mhutter mhutter changed the title Remove certificate management from component Proposal: Remove certificate management from component May 20, 2022
@corvus-ch
Copy link

@megian What is your take on this?

I am a bit worried that removing this could potentially brake a lot of set-ups. Before we do this, I would like to have a description on how to achieve the same results currently covered (given they are actually used somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants