Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some component defaults are only valid for OpenShift 4 #27

Open
simu opened this issue Mar 16, 2022 · 0 comments
Open

Some component defaults are only valid for OpenShift 4 #27

simu opened this issue Mar 16, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@simu
Copy link
Member

simu commented Mar 16, 2022

The component currently provides a number of default Helm values for installing Cilium, cf.

cilium_helm_values:
cni:
binPath: /var/lib/cni/bin
confPath: /var/run/multus/cni/net.d
endpointRoutes:
enabled: true
hubble:
tls:
enabled: false
ipam:
mode: cluster-pool
operator:
clusterPoolIPv4MaskSize: "23"
clusterPoolIPv4PodCIDR: 10.128.0.0/14
kubeProxyReplacement: probe
nativeRoutingCIDR: 10.128.0.0/14
prometheus:
serviceMonitor:
enabled: false
operator:
resources:
requests:
cpu: 100m
memory: 250Mi
limits:
cpu: 100m
memory: 250Mi

Some of these values are only valid for OpenShift 4, for example cni.confPath: /var/run/multus/cni/net.d. Other values are inspired by the OpenShift 4 defaults, such as the default Pod CIDR. However, the Pod CIDR values don't seem to match the OCP4.9 defaults completely (OCP4.9 uses 10.128.0.0/10 by default, not the component's 10.128.0.0/14). In contrast, the Cilium Helm chart defaults to 10.0.0.0/8 for the Pod CIDR.

Actual Behavior

I would expect that the component only provides generally applicable default configs. Currently the component must be reconfigured to be usable on non-OCP4 (or technically, non-multus setups).

Expected Behavior

I'd expect that the component defaults don't contain OpenShift 4-specific configuration and that the component documents a minimal configuration required for OpenShift 4.

@simu simu added the bug Something isn't working label Mar 16, 2022
@simu simu changed the title Some component defaults are OpenShift 4 specific Some component defaults are only valid for OpenShift 4 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant