You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #915, we ensure that new cluster catalog repos are initialized with branch master. However, there's no real requirement that catalog repos must use master as the default branch. Project Syn also doesn't configure ArgoCD to explicitly check out branch master, but instead just lets ArgoCD check out the catalog repo default branch.
We should consider restoring the behavior that Commodore respects the user's init.defaultBranch when creating cluster catalog repositories.
Additionally, we should also respect the user's init.defaultBranch when creating new dependencies. However, to allow that we'll need to update the dependency template to support additional default branches for the tests (cf. projectsyn/commodore-component-template#13). Notably, the dependency sync mechanism already supports arbitrary default branches.
Task deliverables
Commodore respects the user's init.defaultBranch when creating new repositories (catalog or dependencies)
Commodore correctly identifies the local default branch for newly created repos when pushing to a remote repo which doesn't have a default branch yet.
Tests are updated
Documentation is updated
The text was updated successfully, but these errors were encountered:
simu
changed the title
Allow arbitrary default branch name for cluster catalog
Support arbitrary default branch names for cluster catalog and dependency repositories
Feb 9, 2024
Context
In #915, we ensure that new cluster catalog repos are initialized with branch
master
. However, there's no real requirement that catalog repos must usemaster
as the default branch. Project Syn also doesn't configure ArgoCD to explicitly check out branch master, but instead just lets ArgoCD check out the catalog repo default branch.We should consider restoring the behavior that Commodore respects the user's
init.defaultBranch
when creating cluster catalog repositories.Additionally, we should also respect the user's
init.defaultBranch
when creating new dependencies. However, to allow that we'll need to update the dependency template to support additional default branches for the tests (cf. projectsyn/commodore-component-template#13). Notably, the dependency sync mechanism already supports arbitrary default branches.Task deliverables
init.defaultBranch
when creating new repositories (catalog or dependencies)The text was updated successfully, but these errors were encountered: