Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary default branch names for cluster catalog and dependency repositories #916

Open
simu opened this issue Feb 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Feb 9, 2024

Context

In #915, we ensure that new cluster catalog repos are initialized with branch master. However, there's no real requirement that catalog repos must use master as the default branch. Project Syn also doesn't configure ArgoCD to explicitly check out branch master, but instead just lets ArgoCD check out the catalog repo default branch.

We should consider restoring the behavior that Commodore respects the user's init.defaultBranch when creating cluster catalog repositories.

Additionally, we should also respect the user's init.defaultBranch when creating new dependencies. However, to allow that we'll need to update the dependency template to support additional default branches for the tests (cf. projectsyn/commodore-component-template#13). Notably, the dependency sync mechanism already supports arbitrary default branches.

Task deliverables

  • Commodore respects the user's init.defaultBranch when creating new repositories (catalog or dependencies)
  • Commodore correctly identifies the local default branch for newly created repos when pushing to a remote repo which doesn't have a default branch yet.
  • Tests are updated
  • Documentation is updated
@simu simu added the enhancement New feature or request label Feb 9, 2024
@simu simu changed the title Allow arbitrary default branch name for cluster catalog Support arbitrary default branch names for cluster catalog and dependency repositories Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant