Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for components to specify a minimum required Commodore version #479

Open
simu opened this issue Apr 8, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Apr 8, 2022

Summary

As a component developer
I want to be able to specify a minimum Commodore version for my component
So that I can use the latest Commodore features

Context

For some features (most recently #446), it would be quite nice if components could specify that they need a minimum Commodore version, so that new features can be used safely and compiling such components with a Commodore version that's too old will result in a sensible error rather than a cryptic stack trace.

Out of Scope

  • TBD

Acceptance criteria

  • Commodore aborts compilation if it detects any components which require a newer version than its own version.

Implementation Ideas

  • Add optional field minimum_commodore_version (or similar) to component parameter _metadata. If the field is present, Commodore checks against its internal version and aborts compilation if the component requires a newer version than the current Commodore version.
@simu simu added the enhancement New feature or request label Apr 8, 2022
@simu simu changed the title Add support for componens to specify a minimum required Commodore version Add support for components to specify a minimum required Commodore version Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant