Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration test more robust regarding global config version #347

Open
simu opened this issue Jul 6, 2021 · 0 comments
Open

Make integration test more robust regarding global config version #347

simu opened this issue Jul 6, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Jul 6, 2021

Context

The integration test checks that the catalog commit message contains the correct Git commit hash for the global configuration repo.

This check is not robust against changes in the global config repo (the integration test uses https://github.com/projectsyn/getting-started-commodore-defaults) which don't result in a catalog change.

That revision check needs to be made smarter to cope with such changes.

Alternatives

#346 fixes the globalGitRepoRevision to a specific commit sha. This should avoid the issue in the short term, but is not a very satisfying solution.

@simu simu added the enhancement New feature or request label Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant