Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "real" make target for compile #12

Open
simu opened this issue Aug 30, 2022 · 0 comments
Open

Add a "real" make target for compile #12

simu opened this issue Aug 30, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@simu
Copy link
Member

simu commented Aug 30, 2022

Context

We currently mark the make target for component compile as phony. This causes the component to be recompiled, regardless of whether that's necessary. By changing the target to a non-phony target we could leverage make's smart rebuilding for targets which need the compiled component (tests/golden diff/kubent/custom targets operating on the golden test outputs).

While this is not providing a big benefit for many components as we mainly use the targets based on .compile when making changes to the component implementation, there are some cases (e.g. rendering documentation from compiled manifests) where we save some time by reusing the compiled component manifests if no inputs have changed.

The original PR on the modulesync-control repo (projectsyn/modulesync-control#58) keeps the phony `.compile target, so that components which have custom make rules which depend on that target continue to work unchanged.

@simu simu added the enhancement New feature or request label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant