Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autograde feature: Document or remove #74

Open
PhMemmel opened this issue May 9, 2022 · 4 comments
Open

Autograde feature: Document or remove #74

PhMemmel opened this issue May 9, 2022 · 4 comments

Comments

@PhMemmel
Copy link

PhMemmel commented May 9, 2022

Current master has a checkbox autograde in mod_form.php with the label "Selfgrade activity". However, I cannot find a piece of code where this feature is being used at all. I would hence assume that this feature was added 9 years ago, when GeoGebra had an internal way of grading (see also mebis-lp/moodle-qtype_geogebra#47) which it now does not seem to have anymore. I'd be happy if someone who knows about this, could confirm.

If this feature is not available anymore, I'd suggest remove the autograde checkbox and everything related to it (a bit of code and database table field).

If I missed anything and there is such feature like autograde, this should be properly documented (help icon, for example).

@toniginard
Copy link
Member

Hi @PhMemmel,

The value of autograde is currently used here: https://github.com/projectestac/moodle-mod_geogebra/blob/master/attempt.php#L36

I agree it is not documented, but IMO teachers can guess its purpose. Maybe the point here is that the activity must support it.

Best wishes,

@PhMemmel
Copy link
Author

PhMemmel commented Mar 21, 2023

Hi @toniginard,

thank you for answering. I had another look at the code and you are right: The js module picks up the value "grade" from inside the GGB applet and passes it to the attempt.php where it is being used, if the autograde feature is set. So teachers who want to use this, need to have an GGB object "grade" inside their applet and make it return the current grade they want to grade the exercise with. I also just tested it, the feature also works! ;-)

I was thinking that this is some builtin GGB feature (which it is not), so I was wondering where exactly this grading should come from, because I could not find anything related in the GGB API reference.

But apparently it is a mod_geogebra specific feature, it's just not documented or I could not find any documentation on that somewhere. Maybe I will send a pull request to document this feature properly. Thanks again!

@toniginard
Copy link
Member

I don't know what is the origin of this way to pass the grades from GeoGebra to Moodle either. I was already implemented when I started working in this plugin.

@frncesc
Copy link
Member

frncesc commented Mar 21, 2023

Hi @PhMemmel,

In the module documentation you can find a brief explanation of the role played by the "grade" variable:
https://docs.moodle.org/401/en/GeoGebra

It is a simple way to notify Moodle of the result of a Geogebra activity, which can become very complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants