diff --git a/changelogs/unreleased/6099-sunjayBhatia-minor.md b/changelogs/unreleased/6099-sunjayBhatia-minor.md new file mode 100644 index 00000000000..a6c5fc0a3b6 --- /dev/null +++ b/changelogs/unreleased/6099-sunjayBhatia-minor.md @@ -0,0 +1,5 @@ +## Remove Contour container readiness probe initial delay + +The Contour Deployment Contour server container previously had its readiness probe `initialDelaySeconds` field set to 15. +This has been removed from the example YAML manifests and Gateway Provisioner generated Contour Deployment since as of [PR #5672](https://github.com/projectcontour/contour/pull/5672) Contour's xDS server will not start or serve any configuration (and the readiness probe will not succeed) until the existing state of the cluster is synced. +In clusters with few resources this will improve the Contour Deployment's update/rollout time as initial startup time should be low. diff --git a/examples/contour/03-contour.yaml b/examples/contour/03-contour.yaml index 6efbc11821d..a49c3851e4a 100644 --- a/examples/contour/03-contour.yaml +++ b/examples/contour/03-contour.yaml @@ -65,7 +65,6 @@ spec: readinessProbe: tcpSocket: port: 8001 - initialDelaySeconds: 15 periodSeconds: 10 volumeMounts: - name: contourcert diff --git a/examples/render/contour-deployment.yaml b/examples/render/contour-deployment.yaml index ed807e79e0d..bd408dd93ee 100644 --- a/examples/render/contour-deployment.yaml +++ b/examples/render/contour-deployment.yaml @@ -9053,7 +9053,6 @@ spec: readinessProbe: tcpSocket: port: 8001 - initialDelaySeconds: 15 periodSeconds: 10 volumeMounts: - name: contourcert diff --git a/examples/render/contour-gateway.yaml b/examples/render/contour-gateway.yaml index 1e2bdedfd16..80b01219c9c 100644 --- a/examples/render/contour-gateway.yaml +++ b/examples/render/contour-gateway.yaml @@ -9056,7 +9056,6 @@ spec: readinessProbe: tcpSocket: port: 8001 - initialDelaySeconds: 15 periodSeconds: 10 volumeMounts: - name: contourcert diff --git a/examples/render/contour.yaml b/examples/render/contour.yaml index 49970d39bdd..f12b0fe13f1 100644 --- a/examples/render/contour.yaml +++ b/examples/render/contour.yaml @@ -9053,7 +9053,6 @@ spec: readinessProbe: tcpSocket: port: 8001 - initialDelaySeconds: 15 periodSeconds: 10 volumeMounts: - name: contourcert diff --git a/internal/provisioner/objects/deployment/deployment.go b/internal/provisioner/objects/deployment/deployment.go index 8a14230aa04..81b5d2234cb 100644 --- a/internal/provisioner/objects/deployment/deployment.go +++ b/internal/provisioner/objects/deployment/deployment.go @@ -176,11 +176,10 @@ func DesiredDeployment(contour *model.Contour, image string) *appsv1.Deployment }, }, }, - TimeoutSeconds: int32(1), - InitialDelaySeconds: int32(15), - PeriodSeconds: int32(10), - SuccessThreshold: int32(1), - FailureThreshold: int32(3), + TimeoutSeconds: int32(1), + PeriodSeconds: int32(10), + SuccessThreshold: int32(1), + FailureThreshold: int32(3), }, TerminationMessagePath: "/dev/termination-log", TerminationMessagePolicy: corev1.TerminationMessageReadFile,