Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate label for envoy or contour #6488

Open
yangyy93 opened this issue Jun 6, 2024 · 4 comments
Open

Add a separate label for envoy or contour #6488

yangyy93 opened this issue Jun 6, 2024 · 4 comments
Labels
kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@yangyy93
Copy link
Member

yangyy93 commented Jun 6, 2024

What question do you have?:
The field PodAnnotations is now defined in the Spec of ContourDeployment, through which Annotations can be added to contour or envoy pods separately, but for Labels, there is no similar definition. I found that there was a PR (#5543) that implemented this function, but Closed due to merge of #5968.
Because of the merger of #5968, now we can either add annotations to envoy or contour separately, or add (same) annotations to both contour and envoy through gateway.infrastructure.annotation; I think it is a good idea to provide the ability to configure separate labels for envoy or contour for more flexible use.

@yangyy93 yangyy93 added kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Jun 6, 2024
@yangyy93
Copy link
Member Author

@skriss @sunjayBhatia
have any opinions on this issue?

Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 25, 2024
@wilsonwu
Copy link
Member

@skriss @sunjayBhatia any comments for this? We'd like to contribute it.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 12, 2024
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Categorizes an issue as a user question. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

2 participants