diff --git a/internal/envoy/v3/accesslog.go b/internal/envoy/v3/accesslog.go index 094c911222c..7808bf32668 100644 --- a/internal/envoy/v3/accesslog.go +++ b/internal/envoy/v3/accesslog.go @@ -99,7 +99,8 @@ func FileAccessLogJSON(path string, fields contour_api_v1alpha1.AccessLogJSONFie Format: &envoy_config_core_v3.SubstitutionFormatString_JsonFormat{ JsonFormat: jsonformat, }, - Formatters: extensionConfig(extensions), + OmitEmptyValues: true, + Formatters: extensionConfig(extensions), }, }, }), diff --git a/internal/envoy/v3/accesslog_test.go b/internal/envoy/v3/accesslog_test.go index bc6534758d2..e8b0b19318b 100644 --- a/internal/envoy/v3/accesslog_test.go +++ b/internal/envoy/v3/accesslog_test.go @@ -122,6 +122,7 @@ func TestJSONFileAccessLog(t *testing.T) { Path: "/dev/stdout", AccessLogFormat: &envoy_file_v3.FileAccessLog_LogFormat{ LogFormat: &envoy_config_core_v3.SubstitutionFormatString{ + OmitEmptyValues: true, Format: &envoy_config_core_v3.SubstitutionFormatString_JsonFormat{ JsonFormat: &structpb.Struct{ Fields: map[string]*structpb.Value{ @@ -153,6 +154,7 @@ func TestJSONFileAccessLog(t *testing.T) { Path: "/dev/stdout", AccessLogFormat: &envoy_file_v3.FileAccessLog_LogFormat{ LogFormat: &envoy_config_core_v3.SubstitutionFormatString{ + OmitEmptyValues: true, Format: &envoy_config_core_v3.SubstitutionFormatString_JsonFormat{ JsonFormat: &structpb.Struct{ Fields: map[string]*structpb.Value{ @@ -244,6 +246,7 @@ func TestAccessLogLevel(t *testing.T) { Path: "/dev/stdout", AccessLogFormat: &envoy_file_v3.FileAccessLog_LogFormat{ LogFormat: &envoy_config_core_v3.SubstitutionFormatString{ + OmitEmptyValues: true, Format: &envoy_config_core_v3.SubstitutionFormatString_JsonFormat{ JsonFormat: &structpb.Struct{ Fields: map[string]*structpb.Value{}, diff --git a/site/content/docs/main/config/access-logging.md b/site/content/docs/main/config/access-logging.md index f0e0676667e..4dcf20f6401 100644 --- a/site/content/docs/main/config/access-logging.md +++ b/site/content/docs/main/config/access-logging.md @@ -76,6 +76,10 @@ Note that the `DYNAMIC_METADATA` and `FILTER_STATE` Envoy logging operators are See the [example config file][6] to see this used in context. +#### Omitting Logs with Empty Values + +Contour now automatically omits empty fields in Envoy JSON access logs, enhancing clarity and delivering more concise and relevant log outputs by default. + #### Sample Configuration File Here is a sample config: