use atomic bool to be concurrent safe

Signed-off-by: Ahmad Karimi <[email protected]>
projectcontour · Oct 5, 2023 · 310dc2f · 310dc2f
1 parent 8642367
commit 310dc2f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Makefile b/Makefile
@@ -326,6 +326,7 @@ run-e2e:
 	CONTOUR_E2E_IMAGE=$(CONTOUR_E2E_IMAGE) \
 	go run github.com/onsi/ginkgo/v2/ginkgo -tags=e2e -mod=readonly -skip-package=upgrade,bench -keep-going -randomize-suites -randomize-all -poll-progress-after=120s --focus '$(CONTOUR_E2E_TEST_FOCUS)' -r $(CONTOUR_E2E_PACKAGE_FOCUS)
 
+
 .PHONY: cleanup-kind
 cleanup-kind:
 	./test/scripts/cleanup.sh

diff --git a/internal/contour/handler.go b/internal/contour/handler.go
@@ -19,6 +19,7 @@ package contour
 import (
 	"context"
 	"reflect"
+	"sync/atomic"
 	"time"
 
 	"github.com/sirupsen/logrus"
@@ -61,7 +62,7 @@ type EventHandler struct {
 
 	syncTracker *synctrack.SingleFileTracker
 
-	initialDagBuilt bool
+	initialDagBuilt atomic.Bool
 }
 
 func NewEventHandler(config EventHandlerConfig, upstreamHasSynced cache.InformerSynced) *EventHandler {
@@ -112,7 +113,7 @@ func (e *EventHandler) NeedLeaderElection() bool {
 }
 
 func (e *EventHandler) HasBuiltInitialDag() bool {
-	return e.initialDagBuilt
+	return e.initialDagBuilt.Load()
 }
 
 // Implements leadership.NeedLeaderElectionNotification
@@ -205,7 +206,7 @@ func (e *EventHandler) Start(ctx context.Context) error {
 			e.observer.OnChange(latestDAG)
 
 			// Allow XDS server to start (if it hasn't already).
-			e.initialDagBuilt = true
+			e.initialDagBuilt.Store(true)
 
 			// Update the status on objects.
 			for _, upd := range latestDAG.StatusCache.GetStatusUpdates() {