Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI node driver limits/requests issue using operator #7561

Closed
6ripley opened this issue Apr 18, 2023 · 3 comments
Closed

CSI node driver limits/requests issue using operator #7561

6ripley opened this issue Apr 18, 2023 · 3 comments

Comments

@6ripley
Copy link

6ripley commented Apr 18, 2023

Expected Behavior

Limits/requests should be set correctly for CSI node driver

Current Behavior

I'm unable to set limits/requests by editing installation file or daemonset

Steps to Reproduce (for bugs)

  1. Install operator
  2. Trigger installation
  3. Edit installation resource to set requests/limits for csi node driver

Context

Hello,
I'm trying to make calico pods guaranteed by setting resource limits and requests within InstallationSpec, I can see for the CSINodeDriverDaemonset that the docs are pointing to the reference that should be under InstallationSpec but when redirected to the InstallationSpec, it does not list it and is not mentioned under ComponentResources deprecation info.
https://docs.tigera.io/calico/latest/reference/installation/api#operator.tigera.io/v1.CSINodeDriverDaemonSet
https://docs.tigera.io/calico/latest/reference/installation/api#operator.tigera.io/v1.InstallationSpec

@tmjd
Copy link
Member

tmjd commented May 11, 2023

I believe this is fixed with the merging of tigera/docs#638.

@tmjd tmjd closed this as completed May 11, 2023
@Mohsen51
Copy link

I think this documentation update does not solve the issue which is how to set Limits/requests correctly for CSI node driver ...

@caseydavenport
Copy link
Member

Yep - there's only reference documentation for this right now, but there's no walkthrough guide.

I raised this issue against the documentation for this: tigera/docs#673

I think this issue can stay closed - the code supports it, it's just a documentation gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants