Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ID handling in IIIF helper methods #2863

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Fix ID handling in IIIF helper methods #2863

merged 4 commits into from
Jul 17, 2024

Commits on Jul 17, 2024

  1. generate iiif manifest URLs from the resource ID, not the image ID 

    The manifest controller expects the URL to include the exhibit ID and resource
ID, but the indexer has been using the ID of the resource's FeaturedImage
instead.  This doesn't always cause issues, because in many situations the ID of
a resource's FeaturedImage and the ID of the resource itself have the same
numerical representation.  But those numbers can fall out of sync, and manifests
will fail to load.
    @dunn @taylor-steve
    dunn authored and taylor-steve committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    a506073 View commit details
    Browse the repository at this point in the history

  2. Resources::Upload: use FeaturedImage ID for info service 

    This matches the behavior of the other helpers and of CarrierwaveFileResolver
    @dunn @taylor-steve
    dunn authored and taylor-steve committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    8825e42 View commit details
    Browse the repository at this point in the history

  3. fix rubocop errors

    @dunn @taylor-steve
    dunn authored and taylor-steve committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    168a1d2 View commit details
    Browse the repository at this point in the history

  4. Add test for upload to_solr method

    @taylor-steve
    taylor-steve committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0d70438 View commit details
    Browse the repository at this point in the history