Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a "restore default" option for each metadata field in the Dashboard > Metadata section #3126

Closed
marlo-longley opened this issue Sep 17, 2024 · 8 comments · Fixed by #3130

Comments

@marlo-longley
Copy link
Contributor

This is based on sul-dlss/exhibits#2486 -- we decided to propose the change upstream.

@marlo-longley
Copy link
Contributor Author

marlo-longley commented Sep 17, 2024

I have the functionality working for this but I'd like some input on the design. It's a tight space with a lot going on. The placement of the button as seen below isn't great.

Image

Here is how the button looks in the existing Appearance section:
Image

@marlo-longley
Copy link
Contributor Author

WIP available in https://github.com/projectblacklight/spotlight/tree/restore-default-edit for safe keeping until further design decisions are made.

@alundgard
Copy link

Would it be possible to adjust the table header row font size and column width / padding to give more space to the Field name column? Here are some quick mockups.
Screenshot 2024-09-18 at 11 39 14 AM
Screenshot 2024-09-18 at 11 39 05 AM

@marlo-longley
Copy link
Contributor Author

@alundgard thank you! Nice I love the idea of compressing the columns. I will test it out.

@marlo-longley
Copy link
Contributor Author

How's this looking to you @alundgard ? Thanks for your input.

Screenshot 2024-09-18 at 14 51 37

@alundgard
Copy link

That looks good to me @marlo-longley! I might suggest testing how it looks like when the Field name is very long—exceeding the available column space. Probably an unlikely case, but ideally the field name text would wrap to a second line, while the Restore default button stays where it is. (Note also: it looks like we're using sentence case for button text.)

@marlo-longley
Copy link
Contributor Author

marlo-longley commented Sep 18, 2024

Thank you @alundgard. I have the text wrapping to the second line and sentence case implemented below:

Screenshot 2024-09-18 at 16 34 17

The experience of entering a very long label that exceeds the text input box is not good, but since that issue already exists in the current software, if we want to address it I think we should do it as a standalone issue. But I'm glad to have noticed that thanks to your testing suggestion.

Screenshot 2024-09-18 at 16 34 30

@alundgard
Copy link

Lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants