Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blacklight_range_limit triggers deprecations in Blacklight 7.14+ #166

Open
jrochkind opened this issue Feb 1, 2021 · 1 comment
Open

Comments

@jrochkind
Copy link
Member

jrochkind commented Feb 1, 2021

From blacklight_range_limit test suite, these taken from github actions log, but I can see the same ones locally.

Actual output run has some info at the end that may give larger stack traces that make it more clear where these are coming from. I'm having trouble interpreting them all or figuring out the best way to report them readably here.

Some of these are definitley blacklight_range_limit's responsiblity; others of them I'm not totally sure, it could be blacklight triggering it's own deprecation warnings?

This makes it difficult to use blacklight_range_limit with recent blacklights, as it fills up your test output with deprecation warnings.

DEPRECATION WARNING: render_hash_as_hidden_fields is deprecated and will be removed from a future release (Use Blacklight::HiddenSearchStateComponent instead). (called from block in __home_runner_work_blacklight_range_limit_blacklight_range_limit_app_views_blacklight_range_limit__range_limit_panel_html_erb___4404557722848220164_28060 at /home/runner/work/blacklight_range_limit/blacklight_range_limit/app/views/blacklight_range_limit/_range_limit_panel.html.erb:60)

DEPRECATION WARNING: facet_display_value is deprecated and will be removed from blacklight 8.0. (called from facet_display_value at /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/blacklight-7.14.0/app/helpers/blacklight/facets_helper_behavior.rb:300)

DEPRECATION WARNING: Constraints helpers or partials were overridden; not using components. (called from public_send at /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/actionview-6.1.1/lib/action_view/base.rb:247)

DEPRECATION WARNING: [] is deprecated and will be removed from a future release. (called from range_params at /home/runner/work/blacklight_range_limit/blacklight_range_limit/lib/blacklight_range_limit/view_helper_override.rb:90)

DEPRECATION WARNING: Use SearchState#to_h instead of SearchState#to_unsafe_h. (called from normalize_params at /opt/hostedtoolcache/Ruby/2.7.2/x64/lib/ruby/gems/2.7.0/gems/blacklight-7.14.0/lib/blacklight/search_state.rb:34)

DEPRECATION WARNING: render_constraints_filters is deprecated. (called from render_constraints_filters at /home/runner/work/blacklight_range_limit/blacklight_range_limit/lib/blacklight_range_limit/view_helper_override.rb:33)

DEPRECATION WARNING: render_constraints_element is deprecated. (called from block in render_constraints_filters at /home/runner/work/blacklight_range_limit/blacklight_range_limit/lib/blacklight_range_limit/view_helper_override.rb:34)

@barmintor
Copy link
Contributor

I can confirm that main no longer refers to:

  • render_hash_as_hidden_fields
  • render_constraints_element
  • facet_display_value
  • to_unsafe_h

There are some deprecation warnings in the test suite, but they appear to be from tests exercising deprecated behaviors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants