Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"larger" slider does not match chart #132

Closed
jrochkind opened this issue Dec 16, 2019 · 1 comment
Closed

"larger" slider does not match chart #132

jrochkind opened this issue Dec 16, 2019 · 1 comment

Comments

@jrochkind
Copy link
Member

"view larger" is a nice feature.

But the slider does not have the same width as the chart:

Screenshot 2019-12-16 15 09 29

This ends up looking especially confusing when you select a sub-range, since the slider handles and chart selection don't line up:

Screenshot 2019-12-16 15 10 26

If I remove the max-width CSS from the p.range.subsection, it looks right again, with slider handles lining up with selection:

Screenshot 2019-12-16 15 12 18

Not sure if this would have to be done in CSS to apply only to "larger" view, not sure why this max-width was there in the first place or what purpose it serves.
mejackreed added a commit that referenced this issue Jan 13, 2021
@mejackreed
Refactor JavaScript to enable adopter flexibility and customization
cde3347 
Inspired by some of the analysis and comments in #132, this is a
straight refactor to move JavaScript around. This allows for adopters to
modify BlacklightRangeLimit functions, without having to override entire
files.

For example:

```javascript
BlacklightRangeLimit.display_ratio = 1
```

Would produce a square plot area. Previously this type of customization
was not possible.
@mejackreed mejackreed mentioned this issue Jan 13, 2021
Merged
mejackreed added a commit that referenced this issue Jan 13, 2021
@mejackreed
Refactor JavaScript to enable adopter flexibility and customization
3815162 
Inspired by some of the analysis and comments in #132, this is a
straight refactor to move JavaScript around. This allows for adopters to
modify BlacklightRangeLimit functions, without having to override entire
files.

For example:

```javascript
BlacklightRangeLimit.display_ratio = 1
```

Would produce a square plot area. Previously this type of customization
was not possible.
mejackreed added a commit that referenced this issue Jan 13, 2021
@mejackreed
Refactor JavaScript to enable adopter flexibility and customization
e951fb7 
Inspired by some of the analysis and comments in #132, this is a
straight refactor to move JavaScript around. This allows for adopters to
modify BlacklightRangeLimit functions, without having to override entire
files.

For example:

```javascript
BlacklightRangeLimit.display_ratio = 1
```

Would produce a square plot area. Previously this type of customization
was not possible.
@jrochkind
Copy link
Member Author

Current implementation no longer features slider at all; also does not feature the "larger" view currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrochkind