Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite uses anti-pattern #57

Open
atz opened this issue Aug 26, 2016 · 0 comments
Open

Test suite uses anti-pattern #57

atz opened this issue Aug 26, 2016 · 0 comments

Comments

@atz
Copy link
Member

atz commented Aug 26, 2016

Invocations like:

describe "whatever" do 
   include BlacklightAdvancedSearch::FilterParser
...

are failing to properly encapsulate the inclusion. Injecting everything into the rspec example is messy. Also the appearance of affecting only that describe block is misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant