Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate constraints rendering #127

Open
ewlarson opened this issue Feb 17, 2023 · 3 comments · May be fixed by #128
Open

Duplicate constraints rendering #127

ewlarson opened this issue Feb 17, 2023 · 3 comments · May be fixed by #128

Comments

@ewlarson
Copy link

ewlarson commented Feb 17, 2023

Working on a new GeoBlacklight install for UW-Milwaukee. We're seeing advanced search constraint selections rendered twice in the application:

adv_search_bug

I haven't made a lot of customizations here, beyond branding/theming, so the application is pretty vanilla:

  • Rails 7.0.4.2
  • Solr 9.1.1
  • Blacklight 7.33.1
  • GeoBlacklight 4.0.0
  • Blacklight Advanced Search 7.0.0

Codebase is here:
https://github.com/UWM-Libraries/GeoDiscovery/tree/feature/advanced-search

Looks like the BTAA Geoportal also has a similar issue, although there only the constraints render twice, and things are not duplicated in the facets.

Screenshot 2023-02-17 at 4 16 53 PM

  • Rails 6.1.7
  • Solr 8.1.1
  • Blacklight 7.30.0
  • GeoBlacklight 4.0.0
  • Blacklight Advanced Search 7.0.0

I'll dive into the issue further during the GBL Winter community sprint the week of Feb. 27th, but would appreciate any insights beforehand if this rings a bell for anyone.

@ewlarson
Copy link
Author

ewlarson commented Mar 3, 2023

A vanilla BL v7.33.1 install displays this issue, too.

  • Rails 7.0.4.2
  • Blacklight 7.33.1
  • blacklight_advanced_search 7.0.0

Screenshot 2023-03-03 at 9 00 49 AM

@ewlarson
Copy link
Author

ewlarson commented Mar 3, 2023

Forked the gem to work on a fix. Removed a lot of override code and most of the _facet_limit.html.erb view to make things right again:
https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix

  • Rails 7.0.4.2
  • Blacklight 7.33.1
  • ewlarson/blacklight_advanced_search bl7-fix#7fddf35

Screenshot 2023-03-03 at 9 58 42 AM

ewlarson added a commit to ewlarson/blacklight_advanced_search that referenced this issue Mar 3, 2023
Fixes projectblacklight#127

* Removes the render_constraints_filters override method
* Removes the _facet_limit.html.erb code that duplicates facet limits
* Specs run green
@ewlarson
Copy link
Author

ewlarson commented Mar 3, 2023

Okay! This branch is a good PR candidate:
https://github.com/ewlarson/blacklight_advanced_search/tree/bl7-fix-gentle-hands

  • Removes the render_constraints_filters override method
  • Removes the _facet_limit.html.erb code that duplicates facet limits
  • Specs run green

I don't have write access to this repo. Can someone cut a release-7.0 branch that I can pull against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant