Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map object accessible #52

Open
mejackreed opened this issue Aug 4, 2014 · 6 comments
Open

Make map object accessible #52

mejackreed opened this issue Aug 4, 2014 · 6 comments

Comments

@mejackreed
Copy link
Contributor

No description provided.

@tpendragon
Copy link
Member

This was for me - we just need a way to get at the object created here: https://github.com/sul-dlss/blacklight-maps/blob/master/app/assets/javascripts/blacklight-maps/blacklight-maps-browse.js#L24

There should be a standard way to do this for jQuery plugins, but I'd have to look into it.

@mejackreed
Copy link
Contributor Author

If we do this, we may want to refactor the plugin from jQuery style to Leaflet style for better integration with other Leaflet / Leaflet plugins http://leafletjs.com/2013/06/28/leaflet-plugin-authoring-guide.html

@tpendragon
Copy link
Member

👍

It may be that the proper way is a leaflet plugin and then define some data attributes that trigger the spawning of a "map," which sets data on that node. For instance, we've injected the map into our show view as well, and in doing so we've ripped out the generic javascript_tag initializer and written some jQuery code to trigger off a selector. It would have been nice to just have data attributes trigger it.

@ismail44
Copy link

ismail44 commented Dec 3, 2015

Is there any progress being done on this issue? I am working on a project and I would love to be able to extend some of the functionality (i.e. add new controls, add new layers, etc).

@ebenenglish
Copy link
Contributor

@ismail44 As far as I know no one is working on this. If you think you might be interested in taking it on, let me know.

@ismail44
Copy link

ismail44 commented Dec 6, 2015

Sure... I cannot say how quickly it be completed, but I'll go ahead and
take a swing at it.

On Fri, Dec 4, 2015 at 1:37 PM, Eben English [email protected]
wrote:

@ismail44 https://github.com/ismail44 As far as I know no one is
working on this. If you think you might be interested in taking it on, let
me know.


Reply to this email directly or view it on GitHub
#52 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants