Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed mount does not lead to startup error #282

Open
Klaas- opened this issue Jun 28, 2019 · 0 comments · May be fixed by #283
Open

Failed mount does not lead to startup error #282

Klaas- opened this issue Jun 28, 2019 · 0 comments · May be fixed by #283

Comments

@Klaas-
Copy link

Klaas- commented Jun 28, 2019

Hi,
I think the services created by docker-storage-setup need to enforce successful startup. In my case the /var/lib/docker mount had gone into a bad state ("mount: wrong fs type, bad option, bad superblock") but that did not keep docker from starting and using my /var volume directly.

I think the unit files need to be changed like this:
https://github.com/projectatomic/container-storage-setup/blob/master/container-storage-setup.sh#L1330
needs to be RequiredBy=

And https://github.com/projectatomic/container-storage-setup/blob/master/docker-storage-setup.service#L12
needs to also have RequiredBy=docker.service

That way an admin is sure to notice a problem with docker storage.

I'll create a PR.

Greetings
Klaas

Klaas- added a commit to Klaas-/container-storage-setup that referenced this issue Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant