Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_docker_storage_options() should be generalized for inputfile case too #219

Open
rhvgoyal opened this issue Mar 1, 2017 · 3 comments

Comments

@rhvgoyal
Copy link
Collaborator

rhvgoyal commented Mar 1, 2017

get_docker_storage_options() still seem to be hardcoding DOCKER_STORAGE_OPTIONS. And this will not work for general container storage setup.

@rhvgoyal
Copy link
Collaborator Author

rhvgoyal commented Mar 1, 2017

@rhatdan CC

@rhatdan
Copy link
Member

rhatdan commented Mar 1, 2017

We are not supposed to be calling get_docker_storage_options for non docker-storage-setup environments. Which is why we change the STORAGE_OPTIONS to DOCKER_STORAGE_OPTIONS when we use /etc/sysconfig/docker-storage-setup.

@rhvgoyal
Copy link
Collaborator Author

rhvgoyal commented Mar 1, 2017

This is called both for docker and non-docker setups. So function name should be changed too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants