Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't handle devices that end in numbers, such as /dev/loop0 #137

Open
mvollmer opened this issue May 13, 2016 · 2 comments
Open

Can't handle devices that end in numbers, such as /dev/loop0 #137

mvollmer opened this issue May 13, 2016 · 2 comments

Comments

@mvollmer
Copy link

When creating a partition on /dev/loop0, it will be called /dev/loop0p1, but docker-storage-setup will wait for /dev/loop01.

It is probably not important to support loop devices (although they are useful for testing), but other devices might follow a similar labeling scheme and would cause docker-storage-setup to fail in the same way.

@rhatdan
Copy link
Member

rhatdan commented May 14, 2016

@rhvgoyal PTAL

mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue May 16, 2016
mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue May 17, 2016
This also assumes that the block device for the partition is available
right after "udevadm settle".

Fixes projectatomic#137
mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue May 17, 2016
This also assumes that the block device for the partition is available
right after "udevadm settle".

Fixes projectatomic#137
@giuseppe
Copy link
Contributor

I also needed this change to get test_storage.sh (https://github.com/projectatomic/atomic/blob/master/tests/integration/test_storage.sh) pass successfully on my Fedora machine. It works for me modulo the question I had in the code.

mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue Jun 29, 2016
This also assumes that the block device for the partition is available
right after "udevadm settle".

Fixes projectatomic#137
mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue Feb 27, 2017
This also assumes that the block device for the partition is available
right after "udevadm settle".

Fixes projectatomic#137
mvollmer added a commit to mvollmer/docker-storage-setup that referenced this issue Mar 6, 2017
This also assumes that the block device for the partition is available
right after "udevadm settle".

Fixes projectatomic#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants