Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

improve CI testing to better handle changes to roles #324

Open
miabbott opened this issue Jan 29, 2018 · 0 comments
Open

improve CI testing to better handle changes to roles #324

miabbott opened this issue Jan 29, 2018 · 0 comments

Comments

@miabbott
Copy link
Collaborator

Our current methodology for testing PRs is to run any tests that are changed and if a role is changed, just run the improved-sanity-test. It's better than nothing, but less than ideal.

I propose we add some logic to .test_director to determine which roles have changed and run them individually in a dummy playbook. This would allow us to find dependency issues (because we are sloppy with the variable namespace and assume A LOT about what is available), but would also generally improve the kind of testing we are doing on PRs.

This could also grow pretty easily to determining which tests are utilizing the roles and running those tests as well.

@miabbott miabbott changed the title imrpove CI testing to better handle changes to roles improve CI testing to better handle changes to roles Feb 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant