Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image name that includes string '--' not acceptable in docker 1.8+ #51

Open
aweiteka opened this issue Sep 17, 2015 · 3 comments
Open

Comments

@aweiteka
Copy link
Collaborator

Per vendor/redhat/names.md we accept '--' in the build image name. This causes a failure in docker v1.8+.

$ rpm -q docker
docker-1.8.1-3.git32b8b25.fc22.x86_64
$ cat /etc/redhat-release 
Fedora release 22 (Twenty Two)
$ sudo docker build -t test/atomicapp--name .
repository name component must match "[a-z0-9]+(?:[._-][a-z0-9]+)*"
$ sudo docker build -t test/atomicapp-name .
Sending build context to Docker daemon  2.08 MB
Step 0 : FROM centos:centos7
...
@thomasmckay
Copy link
Contributor

To reproduce, attempt to create a new repository on hub.docker.com named "some--thing".

@thomasmckay
Copy link
Contributor

@rhatdan
Copy link
Member

rhatdan commented Sep 18, 2015

Looks like just a bug in the regex that checks.

Changing
[a-z0-9]+(?:[._-][a-z0-9]+)*
to
[a-z0-9]+(?:[._-]+[a-z0-9]+)*

Might fix the problem. Unless docker really wants to force it to be just a single separator field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants