Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening two configuration dolphins blocks a close event from triggering #231

Open
NikhilNarayana opened this issue Sep 5, 2021 · 1 comment

Comments

@NikhilNarayana
Copy link
Member

NikhilNarayana commented Sep 5, 2021

I noticed a very weird interaction where if you open two dolphins for configuring, the close event of the dolphin opened second won't trigger until you close the dolphin you opened first. This doesn't happen when you launch netplay and a replay.

Steps to repro:

  1. Add some log statements in the close events for configuration dolphins.
  2. Configure a Netplay Dolphin.
  3. Configure a Playback Dolphin.
  4. Close Playback Dolphin, notice that the log message doesn't show up.
  5. Close Netplay dolphin, notice that the log message for netplay shows up immediately and then the log message for playback shows up.
@NikhilNarayana NikhilNarayana changed the title bug: opening two configuration dolphins cause an issue bug: opening two configuration dolphins blocks a close event from triggering Sep 5, 2021
@NikhilNarayana NikhilNarayana changed the title bug: opening two configuration dolphins blocks a close event from triggering opening two configuration dolphins blocks a close event from triggering Jan 17, 2022
@FluentCoding
Copy link
Contributor

FluentCoding commented Feb 13, 2022

I looked into this issue and it apparently seems like the main thread of the playback dolphin build doesn't end even if you close the application, so I suppose that this issue has nothing to do with the slippi launcher itself. (see the lower task of the image which is the result of following every step up to step 4)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants