Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type checking is not available while configuring the tiles #1289

Open
2 tasks done
apandura-tibco opened this issue Feb 24, 2020 · 0 comments
Open
2 tasks done
Labels
area/ui kind/bug pkg(parser) Changes affecting parser module

Comments

@apandura-tibco
Copy link
Collaborator

Environment

How are you running Flogo Web?

  • Docker (Specify the docker image that you're using and the command you used to start the container)
  • Other (Provide details of your environment)

Describe the bug

While configuring the input / output / settings of an activity / trigger added to a resource, I am able to assign a different type of data. There is no strict validation happening while configuring the input / settings / outputs.

With a strict type check in the configuration, we can avoid type coerce errors which occurs in run time while executing the resource.

To Reproduce

Steps to reproduce the behavior:

  1. Go to a details page
  2. Click on 'configure' (gear) icon from a tile's menu
  3. Change a string type of input to some random number value
  4. Save the configuration
  5. Notice that no error is thrown to the user while editing or saving the configuration with a type difference.

Expected behavior

When user edits an attribute in the configuration, we should have a type check for primitive values.

Screenshots

image

Ex: In the above screenshot the counterName is of string type but the configuration does not complain when we provide a 435435 value. But we get an error when we run the binary.

@apandura-tibco apandura-tibco added area/ui pkg(parser) Changes affecting parser module labels Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui kind/bug pkg(parser) Changes affecting parser module
Projects
None yet
Development

No branches or pull requests

1 participant