Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sv.json & added translation in ContactList.tsx #1147

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

MagnusLundqvist
Copy link
Contributor

@MagnusLundqvist MagnusLundqvist commented Apr 4, 2024

Pull Request Description
Updated sv.json with missing translations.
Updated sv.json with some minor changes in translation.
Replaced Twitter -> Life Invader, aswell as all "Tweet" & "Retweet" translations in sv.json.
Renamed "APPS_MARKETPLACE" from Blocket -> Marknadsplatsen. (Just to not use real life company names.)
Added "My Number" translation in ContactList.tsx
Added "Nearby Share" translation in ContactList.tsx
Added "MY_NUMBER" aswell as "NEARBY_SHARE" in en.json and sv.json, for easy translations or renaming.

Pull Request Checklist:

  • Have you followed the guidelines in our Contributing document and Code of Conduct?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you built and tested NPWD in-game after the relevant change?

Copy link
Member

@itschip itschip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some syntax errors in the json files you've edited :)

"WRITE_TO_CLIPBOARD_TOOLTIP": "Kopiera {{ content }}",
"WRITE_TO_CLIPBOARD_MESSAGE": "Kopierade {{content}} till urklipp!"
"WRITE_TO_CLIPBOARD_MESSAGE": "Kopierade {{content}} till urklipp!",
""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty string?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry fixed it now :)

@MagnusLundqvist MagnusLundqvist requested a review from itschip April 6, 2024 14:47
@itschip
Copy link
Member

itschip commented Apr 6, 2024

LGTM! Thank you for your contribution!

@itschip itschip merged commit a373bdc into project-error:master Apr 6, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants