Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] NumericAttributeTraits max/min #35328

Closed
lpbeliveau-silabs opened this issue Aug 30, 2024 · 0 comments · Fixed by #35390
Closed

[Feature] NumericAttributeTraits max/min #35328

lpbeliveau-silabs opened this issue Aug 30, 2024 · 0 comments · Fixed by #35390
Labels
feature request feature work needs triage

Comments

@lpbeliveau-silabs
Copy link
Contributor

Feature description

NumericAttributeTraits should have a method allowing to obtain the min/max value for the specific type associatgeed with it.

Platform

all

Platform Version(s)

No response

Anything else?

This was raised here:
#32632 (comment)

This would simplify steps to verify validity of EFS for the Scenes Management cluster.
@lpbeliveau-silabs lpbeliveau-silabs mentioned this issue Aug 30, 2024
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Sep 4, 2024
@bzbarsky-apple
Add MinValue/MaxValue helpers on our NumericAttributeTraits.
39d2244 
Uses the new helpers in SceneHandlerImpl.

Fixes project-chip#35328
@bzbarsky-apple bzbarsky-apple mentioned this issue Sep 4, 2024
Merged
@mergify mergify bot closed this as completed in #35390 Sep 5, 2024
mergify bot pushed a commit that referenced this issue Sep 5, 2024
@bzbarsky-apple
Add MinValue/MaxValue helpers on our NumericAttributeTraits. (#35390)
3621c43 
* Add MinValue/MaxValue helpers on our NumericAttributeTraits.

Uses the new helpers in SceneHandlerImpl.

Fixes #35328

* Address review comments.
@github-project-automation github-project-automation bot moved this from Todo to Done in [Feature] Scenes Sep 5, 2024
ArekBalysNordic pushed a commit to ArekBalysNordic/sdk-connectedhomeip that referenced this issue Nov 28, 2024
@bzbarsky-apple @ArekBalysNordic
Add MinValue/MaxValue helpers on our NumericAttributeTraits. (#35390)
617b3c1 
* Add MinValue/MaxValue helpers on our NumericAttributeTraits.

Uses the new helpers in SceneHandlerImpl.

Fixes project-chip/connectedhomeip#35328

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request feature work needs triage
Projects
[Feature] Scenes
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add MinValue/MaxValue helpers on our NumericAttributeTraits. bzbarsky-apple/connectedhomeip
1 participant
@lpbeliveau-silabs