From be5a9496e91cfb099a8fa39405c12ef60af62315 Mon Sep 17 00:00:00 2001
From: Andrei Litvin <andy314@gmail.com>
Date: Sun, 12 Nov 2023 11:00:12 -0500
Subject: [PATCH] Followup on post-merge comments on #30393 (#30421)

* Use _span

* Remove comment

* Fix alignment

* restyle

* Remove extra bracket

* Fix init

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>
---
 .../placeholder/linux/static-supported-temperature-levels.cpp | 4 +---
 src/app/clusters/scenes-server/SceneTableImpl.cpp             | 1 -
 .../time-synchronization-server.cpp                           | 2 +-
 src/lib/core/CHIPError.h                                      | 2 +-
 4 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/examples/placeholder/linux/static-supported-temperature-levels.cpp b/examples/placeholder/linux/static-supported-temperature-levels.cpp
index 88ed689a6032a4..14a1087d230a4d 100644
--- a/examples/placeholder/linux/static-supported-temperature-levels.cpp
+++ b/examples/placeholder/linux/static-supported-temperature-levels.cpp
@@ -27,9 +27,7 @@ using namespace chip::app::Clusters::TemperatureControl;
 using chip::Protocols::InteractionModel::Status;
 
 // TODO: Configure your options for each endpoint
-CharSpan AppSupportedTemperatureLevelsDelegate::temperatureLevelOptions[] = { CharSpan::fromCharString("Hot"),
-                                                                              CharSpan::fromCharString("Warm"),
-                                                                              CharSpan::fromCharString("Cold") };
+CharSpan AppSupportedTemperatureLevelsDelegate::temperatureLevelOptions[] = { "Hot"_span, "Warm"_span, "Cold"_span };
 
 const AppSupportedTemperatureLevelsDelegate::EndpointPair AppSupportedTemperatureLevelsDelegate::supportedOptionsByEndpoints
     [EMBER_AF_TEMPERATURE_CONTROL_CLUSTER_SERVER_ENDPOINT_COUNT] = {
diff --git a/src/app/clusters/scenes-server/SceneTableImpl.cpp b/src/app/clusters/scenes-server/SceneTableImpl.cpp
index ed0a86ab282377..7f5870f0ecf2b3 100644
--- a/src/app/clusters/scenes-server/SceneTableImpl.cpp
+++ b/src/app/clusters/scenes-server/SceneTableImpl.cpp
@@ -209,7 +209,6 @@ struct SceneTableData : public SceneTableEntry, PersistentData<kPersistentSceneB
 
     CHIP_ERROR Serialize(TLV::TLVWriter & writer) const override
     {
-        // TODO: if we have mNameLength, should this bin ByteSpan instead?
         CharSpan nameSpan(mStorageData.mName, mStorageData.mNameLength);
         TLV::TLVType container;
         ReturnErrorOnFailure(writer.StartContainer(TLV::AnonymousTag(), TLV::kTLVType_Structure, container));
diff --git a/src/app/clusters/time-synchronization-server/time-synchronization-server.cpp b/src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
index f57d52bcdbcc2d..7750c56be352d0 100644
--- a/src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
+++ b/src/app/clusters/time-synchronization-server/time-synchronization-server.cpp
@@ -551,7 +551,7 @@ void TimeSynchronizationServer::InitTimeZone()
     for (auto & tzStore : mTimeZoneObj.timeZoneList)
     {
         memset(tzStore.name, 0, sizeof(tzStore.name));
-        tzStore.timeZone = { .offset = 0, .validAt = 0, .name = MakeOptional(CharSpan(tzStore.name, 0)) };
+        tzStore.timeZone = { .offset = 0, .validAt = 0, .name = chip::NullOptional };
     }
 }
 
diff --git a/src/lib/core/CHIPError.h b/src/lib/core/CHIPError.h
index ab0912c0ffb17e..0bc63cb055f59c 100644
--- a/src/lib/core/CHIPError.h
+++ b/src/lib/core/CHIPError.h
@@ -588,7 +588,7 @@ using CHIP_ERROR = ::chip::ChipError;
  *    Invalid UTF8 string (contains some characters that are invalid)
  *
  */
-#define CHIP_ERROR_INVALID_UTF8                       CHIP_CORE_ERROR(0x12)
+#define CHIP_ERROR_INVALID_UTF8                                CHIP_CORE_ERROR(0x12)
 
 /**
  *  @def CHIP_ERROR_INTEGRITY_CHECK_FAILED