From 69eb2252915da41141331e20ea4c4e92e39d808e Mon Sep 17 00:00:00 2001 From: Andrei Litvin Date: Wed, 21 Feb 2024 20:49:35 -0500 Subject: [PATCH] Remove platform linux from checks. Very rough, but better it seems than disabling enum cast checks --- .clang-tidy | 1 - scripts/run-clang-tidy-on-compile-commands.py | 6 +++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 9f53e79b81808e..0b50ad25f1f5db 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -36,7 +36,6 @@ Checks: > -clang-analyzer-cplusplus.Move, -clang-analyzer-deadcode.DeadStores, -clang-analyzer-nullability.NullablePassedToNonnull, - -clang-analyzer-optin.core.EnumCastOutOfRange, -clang-analyzer-optin.cplusplus.UninitializedObject, -clang-analyzer-optin.cplusplus.VirtualCall, -clang-analyzer-optin.osx.cocoa.localizability.EmptyLocalizationContextChecker, diff --git a/scripts/run-clang-tidy-on-compile-commands.py b/scripts/run-clang-tidy-on-compile-commands.py index d9dc6cdcfa374e..0773fe3ce2fcf9 100755 --- a/scripts/run-clang-tidy-on-compile-commands.py +++ b/scripts/run-clang-tidy-on-compile-commands.py @@ -371,7 +371,11 @@ def Check(self): "--file-exclude-regex", # NOTE: if trying '/third_party/' note that a lot of sources are routed through # paths like `../../examples/chip-tool/third_party/connectedhomeip/src/` - default="/(repo|zzz_generated)/", + # + # NOTE: src/platform/Linux disabled due to glib errors. Seemed like a better + # tradeoff that completely disabling EnumCastoutOfRange which seems + # to catch errors + default="/(repo|zzz_generated|src/platform/Linux)/", help="Regular expression to apply to the file paths for running. Skip overrides includes.", ) @click.option(