Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Refactor backend's ChipTool class #95

Closed
ccruzagralopes opened this issue Nov 21, 2023 · 1 comment
Closed

[Enhancement] Refactor backend's ChipTool class #95

ccruzagralopes opened this issue Nov 21, 2023 · 1 comment
Assignees

Comments

@ccruzagralopes
Copy link
Contributor

ccruzagralopes commented Nov 21, 2023

Description

Currently, the ChipTool class handles:

  • SDK container lifetime
  • SDK YAML runner setup and use
  • chip-tool/app binaries execution for commissioning/decommissioning

And it will handle even more once the SDK python tests are integrated.

Additional Information

Comment from @mikaelhm in the PR project-chip/certification-tool-backend#29:

I'm wondering if we need some refactoring of this ChipTool class (maybe not needed for this PR)

But it's getting quite bloated, and it's really hard to follow what exactly is happening in a method like this.

I think we should split it in three classes:

  • ChipCertBinsContainer
  • ChipTool (covering running chip-tool/chip-app)
  • MatterSDKRunner (for running yaml tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant