Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Test steps are not being shows for all python tests #457

Closed
cecille opened this issue Oct 3, 2024 · 7 comments
Closed

[Bug] Test steps are not being shows for all python tests #457

cecille opened this issue Oct 3, 2024 · 7 comments
Assignees
Labels
Backend Bug Something isn't working Found_SVE_1.4

Comments

@cecille
Copy link

cecille commented Oct 3, 2024

Describe the bug

There are a bunch of tests where we have steps_ functions defined, but the individual steps are not displayed in the GUI

Steps to reproduce the behavior

This happens for opstate tests for example, but I assume also others.

Expected behavior

No response

Log files

No response

PICS file

No response

Screenshots

No response

Environment

No response

Additional Information

No response

@fabiowmm
Copy link
Contributor

@antonio-amjr can you try to reproduce this with TC_OPSTATE_2_1.py?

@antonio-amjr
Copy link
Contributor

@antonio-amjr can you try to reproduce this with TC_OPSTATE_2_1.py?

Sure, I'll take a look

@antonio-amjr
Copy link
Contributor

@cecille and @fabiowmm ,

The OPSTATE and OVENOPSTATE tests are falling into the legacy python test category.
That is happening because the Python Test Parser is expecting a ast.List type from the "steps_" method, but instead is receiving a ast.Call.

So the problem is that the OPSTATE/OVENOPSTATE tests are the only ones, I believe, that are using another method to retrieve the steps, like shown below:

Screenshot 2024-10-11 at 09 15 25
The python_test_parser.py method verifying the test steps type.

Screenshot 2024-10-11 at 09 11 58
The original TC_OPSTATE_2_1 steps method that triggers the error.

Screenshot 2024-10-11 at 09 22 48
Changing the TC_OPSTATE_2_1 steps method successfully adds to the correct suite and show the steps in execution.


I think that the steps are specific to tests and shouldn't be inside the TC_OpstateCommon.py at all. And to solve this would be just moving the steps to each related file.

What is your take on this?

@antonio-amjr
Copy link
Contributor

Note

It seems that there's a feature already in progress that solves this issue:

@fabiowmm fabiowmm added the SDK label Oct 18, 2024
@rquidute
Copy link
Contributor

Related issue: #484

@fabiowmm
Copy link
Contributor

fabiowmm commented Dec 5, 2024

@rquidute is this solved?

@rquidute
Copy link
Contributor

rquidute commented Dec 5, 2024

Yes @fabiowmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Bug Something isn't working Found_SVE_1.4
Projects
None yet
Development

No branches or pull requests

4 participants