Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secp256k1 for ECDSA signature validation #132

Open
bitmarkcc opened this issue Jan 14, 2024 · 0 comments
Open

secp256k1 for ECDSA signature validation #132

bitmarkcc opened this issue Jan 14, 2024 · 0 comments

Comments

@bitmarkcc
Copy link

With the newer openssl (as in Ubuntu 22) some unit tests fail, so I've implemented Bitcoin's custom library for ECDSA crypto for validating signatures. For new blocks, signatures have to be strictly DER, but for prefork blocks that's not the case, as well as in the unit tests. This library can be useful for other ECDSA crypto operations, but for now we can use it just for the signature validation. Here is the patch: bitmarkcc@e6bdd4b

There are many new files added in the src/secp256k1 dir. You can run a diff and check that they are the same as Bitcoin's (thus safe). The rest of the files changed are configure.ac, src/Makefile.am, src/Makefile.include, src/key.cpp, src/test/Makefile.am.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant