Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASR Fallback seems not installed before it is required? #451

Open
philipp2310 opened this issue May 27, 2021 · 4 comments
Open

ASR Fallback seems not installed before it is required? #451

philipp2310 opened this issue May 27, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@philipp2310
Copy link
Member

As it seems the fallback ASR is installed only when it is used - most of the time it should be used when the internet was dropped -> but how to install in that case?

@philipp2310 philipp2310 added the bug Something isn't working label May 27, 2021
@Psychokiller1888
Copy link
Member

That's.... true.... :)

@philipp2310
Copy link
Member Author

and a second thing: Alice changes to the fallback ASR when the internet connection is lost, even if the main ASR doesn't require internet

@Psychokiller1888
Copy link
Member

	def onInternetLost(self):
		if self._asr.isOnlineASR:
			self.logInfo('Internet lost, switching to offline Asr')
			self.restartEngine()

I don't get why she would switch?

@philipp2310
Copy link
Member Author

philipp2310 commented May 31, 2021

Ha, yeah, you are right, it is not on loss of internet but on reestablishing:

			self.logInfo('Connected to internet, switching Asr')
			self.restartEngine()

a restart is forced even though no onlineASR or change is required.
Easy to solve as user by setting the Fallback == the main STT -> there currently isn't a reason to use the fallback apart from a failing start of the main ASR (model missing, training not consistent).

I'll adjust it so you can have a real fallback when the main ASR crashes - without relevance of the internet (e.g. Coqui as "hot" software with potential changes, with deepspeech 6.1 as a solid fallback that won't ever crash)

Edit: Even easier: if both ASR are offline ASR, the "keepASR offline" should be set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants