Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add securityContext to controller helm chart #664

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Oct 3, 2023

What this PR does / why we need it:
securityContext setting is missing in Controller helm chart. Add it to the chart to take the value for securityContext.

Special notes for your reviewer:

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

@johnsonshih
Copy link
Contributor Author

/version patch

@github-actions github-actions bot added the version/patch Patch version change is needed label Oct 4, 2023
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@johnsonshih johnsonshih merged commit a233713 into project-akri:main Oct 4, 2023
1 check passed
@johnsonshih johnsonshih deleted the user/jshih/controller-security-context branch October 4, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version/patch Patch version change is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants