Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not a fair comparison #2

Open
lievendf opened this issue May 25, 2021 · 0 comments
Open

Not a fair comparison #2

lievendf opened this issue May 25, 2021 · 0 comments

Comments

@lievendf
Copy link

lievendf commented May 25, 2021 •
edited
Loading

Comparing the OpenEdge BasicQuery implementation to the C# version, some things are omitted that don't make this a fair comparison.

  • In the .p the database connection is implied, meaning it either happened through startup parameters or other code not shown here (since the connection needs to be made outside this .p).
  • No error handling in the .p. Records might be locked. At least some code to anticipate this could be added instead of using the very optimistic "share-lock" default. The C# code has try/catch blocks, so the .p should as well, or at least have some IF LOCKED logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lievendf